Skip to content

Prop-types + dependency updates - #2

Merged
diegocouto merged 9 commits into
masterfrom
develop
Nov 6, 2017
Merged

Prop-types + dependency updates#2
diegocouto merged 9 commits into
masterfrom
develop

Conversation

@diegocouto

Copy link
Copy Markdown
Owner

This is a merge between the pull request #314 and an updated dependencies list in package.json.

@diegocouto
diegocouto merged commit 35195ec into master Nov 6, 2017
@StanSarr

StanSarr commented Nov 8, 2017

Copy link
Copy Markdown

@diegocouto I'm gonna use your Shoutem UI. Is it ok for you bud?
Do you another errors, bugs etc...?

@diegocouto

diegocouto commented Nov 8, 2017

Copy link
Copy Markdown
Owner Author

Sure, @StanSarr! If you find any other issues with Shoutem UI dependencies that should be updated to work well with React v16, just let me know that I'll update it. 😁

Edit
Regarding the errors, I'm currently using it on a project and it works just fine.

@StanSarr

StanSarr commented Nov 9, 2017

Copy link
Copy Markdown

Cool thank you. I'll let you know 👍

@dailycommit

Copy link
Copy Markdown

hey @diegocouto the original shoutem/ui does not work with react v16.0.0
How do I install your version ?
npm install @shoutem/ui#pull/314/head does it work?

@diegocouto

Copy link
Copy Markdown
Owner Author

Hi, @dailycommit! Yep, unfortunately, it doesn't. 😞

As I've merged the proposed changes on my fork and pushed them to master, you can use it through: npm install diegocouto/ui

@dailycommit

Copy link
Copy Markdown

Thanks for your help @diegocouto, It seems I'll have to change many codes for diegocouto/ui 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants